Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reverse fields #579

Merged
merged 3 commits into from Dec 6, 2022
Merged

Remove reverse fields #579

merged 3 commits into from Dec 6, 2022

Conversation

ncfavier
Copy link
Member

@ncfavier ncfavier commented Dec 6, 2022

Their initial purpose was suffix queries, but this should be handled by the wildcard queries now.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022 •
edited

🚀 Deployed on https://638fc46808c5ce1957f36cf0--nixos-search.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 6, 2022 10:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 6, 2022 11:54 Inactive
@ncfavier
Copy link
Member Author

ncfavier commented Dec 6, 2022 •
edited

No regression on #537: extradep
No regression on #170: codium
EDIT: regression #583: numpy
make returns mostly make* rather than *make packages, but is otherwise still as unhelpful.

@ncfavier ncfavier marked this pull request as ready for review December 6, 2022 12:06
@ncfavier ncfavier requested review from garbas and ysndr and removed request for garbas December 6, 2022 12:06
@ysndr
Copy link
Member

ysndr commented Dec 6, 2022

Happy we can leave these reverse fields behind they were just noise in the code for the most part

garbas
garbas approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

But lets test it in this PR before we merge it. Was the import already triggered?

@ncfavier
Copy link
Member Author

ncfavier commented Dec 6, 2022

Yes

@garbas
Copy link
Member

garbas commented Dec 6, 2022

Ignore my comment above. I didn't see you've already tested this.

@ncfavier
Remove reverse fields
f89e246 
Their initial purpose was suffix queries, but this should be handled by
the wildcard queries now.
@ncfavier
Remove "attribute query" fields
2d3bc3e 
This is mostly dead code after removing reverse fields, since the
`query` function was only used by the `Reversable` implementation.
This should be handled by wildcard queries anyway.
@ncfavier
Bump VERSION
41c0827
@github-actions github-actions bot temporarily deployed to pull request December 6, 2022 22:38 Inactive
@ncfavier
Copy link
Member Author

ncfavier commented Dec 6, 2022

Triggered an import, will merge when it's done

@ncfavier ncfavier merged commit 4bea45b into main Dec 6, 2022
@ncfavier ncfavier deleted the remove-reverse-fields branch December 6, 2022 22:58
@ncfavier ncfavier mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

@ysndr ysndr ysndr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncfavier @ysndr @garbas