Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
pythonPackages.pyarrow: remove dead code in preCheck, use pytestCheck…
…Hook
  • Loading branch information
veprbl authored and jonringer committed Mar 31, 2020
1 parent a7e4dba commit 03ccfe2
Showing 1 changed file with 5 additions and 31 deletions.
36 changes: 5 additions & 31 deletions pkgs/development/python-modules/pyarrow/default.nix
@@ -1,4 +1,4 @@
{ lib, fetchpatch, buildPythonPackage, python, isPy3k, arrow-cpp, cmake, cython, futures, hypothesis, numpy, pandas, pytest, pytest-lazy-fixture, pkgconfig, setuptools_scm, six }:
{ lib, fetchpatch, buildPythonPackage, python, isPy3k, arrow-cpp, cmake, cython, futures, hypothesis, numpy, pandas, pytestCheckHook, pytest-lazy-fixture, pkgconfig, setuptools_scm, six }:

let
_arrow-cpp = arrow-cpp.override { inherit python; };
Expand All @@ -23,7 +23,7 @@ buildPythonPackage rec {

nativeBuildInputs = [ cmake cython pkgconfig setuptools_scm ];
propagatedBuildInputs = [ numpy six ] ++ lib.optionals (!isPy3k) [ futures ];
checkInputs = [ hypothesis pandas pytest pytest-lazy-fixture ];
checkInputs = [ hypothesis pandas pytestCheckHook pytest-lazy-fixture ];

PYARROW_BUILD_TYPE = "release";
PYARROW_WITH_PARQUET = true;
Expand All @@ -34,47 +34,21 @@ buildPythonPackage rec {
# ourselves
"-DCMAKE_POLICY_DEFAULT_CMP0025=NEW"
];
ARROW_HOME = _arrow-cpp;
PARQUET_HOME = _arrow-cpp;

dontUseCmakeConfigure = true;

preBuild = ''
export PYARROW_PARALLEL=$NIX_BUILD_CORES
'';

dontUseSetuptoolsCheck = true;
preCheck = ''
rm pyarrow/tests/test_jvm.py
rm pyarrow/tests/test_hdfs.py
rm pyarrow/tests/test_cuda.py
# fails: "ArrowNotImplementedError: Unsupported numpy type 22"
substituteInPlace pyarrow/tests/test_feather.py --replace "test_timedelta_with_nulls" "_disabled"
# runs out of memory on @grahamcofborg linux box
substituteInPlace pyarrow/tests/test_feather.py --replace "test_large_dataframe" "_disabled"
# probably broken on python2
substituteInPlace pyarrow/tests/test_feather.py --replace "test_unicode_filename" "_disabled"
# fails "error: [Errno 2] No such file or directory: 'test'" because
# nix_run_setup invocation somehow manages to import deserialize_buffer.py
# when it is not intended to be imported at all
rm pyarrow/tests/deserialize_buffer.py
substituteInPlace pyarrow/tests/test_feather.py --replace "test_deserialize_buffer_in_different_process" "_disabled"
# Fails to bind a socket
# "PermissionError: [Errno 1] Operation not permitted"
substituteInPlace pyarrow/tests/test_ipc.py --replace "test_socket_" "_disabled"
'';

ARROW_HOME = _arrow-cpp;
PARQUET_HOME = _arrow-cpp;

checkPhase = ''
mv pyarrow/tests tests
rm -rf pyarrow
mkdir pyarrow
mv tests pyarrow/tests
pytest -v
'';

meta = with lib; {
Expand Down

0 comments on commit 03ccfe2

Please sign in to comment.