Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Revert "nixos/ddclient: make RuntimeDirectory and configFile private"
  • Loading branch information
infinisil committed Dec 29, 2018
1 parent 8d7da06 commit 0702543
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions nixos/modules/services/networking/ddclient.nix
Expand Up @@ -182,10 +182,9 @@ with lib;
serviceConfig = rec {
DynamicUser = true;
RuntimeDirectory = StateDirectory;
RuntimeDirectoryMode = "0750";
StateDirectory = builtins.baseNameOf dataDir;
Type = "oneshot";
ExecStartPre = "!${lib.getBin pkgs.coreutils}/bin/install -m660 ${cfg.configFile} /run/${RuntimeDirectory}/ddclient.conf";
ExecStartPre = "!${lib.getBin pkgs.coreutils}/bin/install -m666 ${cfg.configFile} /run/${RuntimeDirectory}/ddclient.conf";
ExecStart = "${lib.getBin pkgs.ddclient}/bin/ddclient -file /run/${RuntimeDirectory}/ddclient.conf";
};
};
Expand Down

3 comments on commit 0702543

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this make the secrets in cfg.configFile world readable again?!

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please explain why the change is reverted in the commit message.

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infinisil ping

Please sign in to comment.