From 64d0029e285983c599516e1ec62d9997bb28ab53 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Fri, 30 Jun 2023 11:16:28 -0700 Subject: [PATCH] alacritty: --add-rpath instead of --set-rpath As reported by @blucoat in https://github.com/NixOS/nixpkgs/issues/219213 alacritty's RPATH is missing many of the libraries which it links to, including for example glibc. The problem was diagnosed by @kchibisov as being caused by alacritty's use of `--set-rpath` (which completely replaces the rpath) instead of `--add-rpath` (which adds additional entries to the rpath): https://github.com/NixOS/nixpkgs/issues/219213#issuecomment-1507655801 This commit implements @kchibisov's idea to change `--set-rpath` to `--add-rpath`: https://github.com/NixOS/nixpkgs/issues/219213#issuecomment-1507691822 Closes #219213 --- pkgs/applications/terminal-emulators/alacritty/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/terminal-emulators/alacritty/default.nix b/pkgs/applications/terminal-emulators/alacritty/default.nix index 9f20a2d0576e44a..2a6f958b1a27fb0 100644 --- a/pkgs/applications/terminal-emulators/alacritty/default.nix +++ b/pkgs/applications/terminal-emulators/alacritty/default.nix @@ -104,7 +104,7 @@ rustPlatform.buildRustPackage rec { # As a workaround, strip manually before running patchelf. $STRIP -S $out/bin/alacritty - patchelf --set-rpath "${lib.makeLibraryPath rpathLibs}" $out/bin/alacritty + patchelf --add-rpath "${lib.makeLibraryPath rpathLibs}" $out/bin/alacritty '' ) + ''