Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcom driver doesn't build with generated config #12595

Closed
georgewhewell opened this issue Jan 24, 2016 · 4 comments
Closed

broadcom driver doesn't build with generated config #12595

georgewhewell opened this issue Jan 24, 2016 · 4 comments
Assignees

Comments

@georgewhewell
Copy link
Contributor

@georgewhewell georgewhewell commented Jan 24, 2016

In the configuration generated by nixos-generate-config, the following line enabled the broadcom driver:

boot.extraModulePackages = [ "${config.boot.kernelPackages.broadcom_sta}" ];

nixos-rebuild fails with:

error: path ‘/nix/store/4s1fc4sqbl41wpz3lfx894aamh1k8znl-broadcom-sta-6.30.223.248-4.4’ does not exist and cannot be created

If I replace the line in my config with

boot.extraModulePackages = [ config.boot.kernelPackages.broadcom_sta ];

the driver is built correctly. This behaviour started happening fairly recently (~1 week). Prior to this, the first variant worked fine.

@copumpkin
Copy link
Member

@copumpkin copumpkin commented Jan 24, 2016

This sounds more like a Nix issue than a nixpkgs one, but let's leave it here and highlight @edolstra.

Loading

@thall
Copy link
Contributor

@thall thall commented Jan 24, 2016

nixos/modules/installer/tools/nixos-generate-config.pl:151 was changed in commit b11f662

Loading

@henrytill
Copy link
Contributor

@henrytill henrytill commented Jan 24, 2016

@copumpkin: I suggested posting the issue here based on #3560 (comment) and NixOS/nix#299 (comment)

Loading

@vcunat vcunat self-assigned this Jan 25, 2016
@vcunat vcunat closed this in 3e1599f Jan 25, 2016
vcunat added a commit that referenced this issue Jan 25, 2016
@vcunat
Copy link
Member

@vcunat vcunat commented Jan 25, 2016

I don't know why it has stopped working, but anyway, passing this as a string wasn't a good idea. Hacked a fix and pushed to master and 15.09.

Loading

vcunat added a commit that referenced this issue Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants