broadcom driver doesn't build with generated config #12595

Closed
georgewhewell opened this Issue Jan 24, 2016 · 4 comments

Projects

None yet

5 participants

@georgewhewell
Contributor

In the configuration generated by nixos-generate-config, the following line enabled the broadcom driver:

boot.extraModulePackages = [ "${config.boot.kernelPackages.broadcom_sta}" ];

nixos-rebuild fails with:

error: path ‘/nix/store/4s1fc4sqbl41wpz3lfx894aamh1k8znl-broadcom-sta-6.30.223.248-4.4’ does not exist and cannot be created

If I replace the line in my config with

boot.extraModulePackages = [ config.boot.kernelPackages.broadcom_sta ];

the driver is built correctly. This behaviour started happening fairly recently (~1 week). Prior to this, the first variant worked fine.

@copumpkin
Member

This sounds more like a Nix issue than a nixpkgs one, but let's leave it here and highlight @edolstra.

@thall
Contributor
thall commented Jan 24, 2016

nixos/modules/installer/tools/nixos-generate-config.pl:151 was changed in commit b11f662

@henrytill
Contributor

@copumpkin: I suggested posting the issue here based on #3560 (comment) and NixOS/nix#299 (comment)

@vcunat vcunat self-assigned this Jan 25, 2016
@vcunat vcunat closed this in 3e1599f Jan 25, 2016
@vcunat vcunat added a commit that referenced this issue Jan 25, 2016
@vcunat vcunat nixos-generate-config: fix #12595: broadcom quoting
(cherry picked from commit 3e1599f)
55b0326
@vcunat
Member
vcunat commented Jan 25, 2016

I don't know why it has stopped working, but anyway, passing this as a string wasn't a good idea. Hacked a fix and pushed to master and 15.09.

@therealpxc therealpxc pushed a commit to therealpxc/nixpkgs that referenced this issue Feb 5, 2016
@vcunat vcunat + Patrick Callahan nixos-generate-config: fix #12595: broadcom quoting ca04099
@vcunat vcunat added a commit that referenced this issue Mar 29, 2016
@vcunat vcunat manual rl-16.03: document broadcom issue #12595
(cherry picked from commit d9b98b6)
12528e5
@peterhoeg peterhoeg added a commit to peterhoeg/nixpkgs that referenced this issue Apr 6, 2016
@vcunat @peterhoeg vcunat + peterhoeg manual rl-16.03: document broadcom issue #12595 92ad3ea
@ckauhaus ckauhaus added a commit to ckauhaus/nixpkgs that referenced this issue Apr 13, 2016
@vcunat @ckauhaus vcunat + ckauhaus manual rl-16.03: document broadcom issue #12595
(cherry picked from commit d9b98b6)
67dcd02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment