Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound.enableMediaKeys values in percent instead of hardware value #17068

Closed
dermetfan opened this issue Jul 18, 2016 · 2 comments
Closed

sound.enableMediaKeys values in percent instead of hardware value #17068

dermetfan opened this issue Jul 18, 2016 · 2 comments
Labels
0.kind: enhancement Add something new

Comments

@dermetfan
Copy link
Member

dermetfan commented Jul 18, 2016

Issue description

sound.enableMediaKeys works, but changes the volume by +/- 1 (hardware value). In practice this makes no perceptible difference, at least on some systems. I'd like to propose to change by +/- 1 % instead.

I would send a PR but am not yet involved enough to try and test this myself. The necessary change is merely an additional %-sign in the amixer command line in nixos/modules/services/audio/alsa.nix:

# "Lower Volume" media key
{ keys = [ 114 ]; events = [ "key" "rep" ]; command = "${alsaUtils}/bin/amixer -q set Master 1%- unmute"; }

# "Raise Volume" media key
{ keys = [ 115 ]; events = [ "key" "rep" ]; command = "${alsaUtils}/bin/amixer -q set Master 1%+ unmute"; }

Technical details

  • System: 16.09pre85931.125ffff (Flounder)
  • Nix version: nix-env (Nix) 1.11.2
  • Nixpkgs version: 16.09pre85931.125ffff
@FRidh FRidh added the 0.kind: enhancement Add something new label Jul 18, 2016
@laMudri
Copy link
Contributor

laMudri commented Jul 23, 2016

Do make this an option, and default false for least surprise to upgrading users. I might do it myself if I get some spare time.

@dermetfan
Copy link
Member Author

Closing as this has been handled in #21538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new
Projects
None yet
Development

No branches or pull requests

3 participants