Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan validation layer description no longer contains an absolute path to the layer shared object #215607

Closed
expipiplus1 opened this issue Feb 10, 2023 · 0 comments · Fixed by #215612

Comments

@expipiplus1
Copy link
Contributor

Describe the bug

The validation layer shared object is no longer findable unless it's in the library search path (add it to LD_LIBRARY_PATH for a quick workaround).

The update included here: #206384 has made it so that this patch no longer does what it's intending to

# Include absolute paths to layer libraries in their associated
# layer definition json files.
postPatch = ''
sed "s|\([[:space:]]*set(INSTALL_DEFINES \''${INSTALL_DEFINES} -DRELATIVE_LAYER_BINARY=\"\)\(\$<TARGET_FILE_NAME:\''${TARGET_NAME}>\")\)|\1$out/lib/\2|" -i layers/CMakeLists.txt
'';

Steps To Reproduce

Notify maintainers

@PedroHLC
@Ralith

kira-bruneau pushed a commit that referenced this issue Feb 10, 2023
Fixes #215607

This solution (rather than patching the cmake source) is in line with how the other vulkan layer packages do things
gador pushed a commit to gador/nixpkgs that referenced this issue Feb 13, 2023
Fixes NixOS#215607

This solution (rather than patching the cmake source) is in line with how the other vulkan layer packages do things
gador pushed a commit to gador/nixpkgs that referenced this issue Jun 22, 2024
Fixes NixOS#215607

This solution (rather than patching the cmake source) is in line with how the other vulkan layer packages do things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant