Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Set CONFIG_SHELL to stdenv.shell in default builder #233

Closed
7c6f434c opened this Issue Dec 27, 2012 · 7 comments

Comments

Projects
None yet
5 participants
Member

7c6f434c commented Dec 27, 2012

There are cases where chroot builds are not practical (for example, when you are still building stdenv on a platform not supported by Hydra). ./configure will take /bin/bash as shell before checking PATH, but this can be overriden with CONFIG_SHELL environment variable.

Maybe it is a good idea to set this variable? Or maybe just for stdenv and nix dependencies (afterwards it is possible to use chroot builds)

Member

viric commented Dec 27, 2012

Using /bin/bash, if it exists and runs, should not be any problem.

On the other hand, such variable could be set in the preHook of stdenvLinux.

Member

7c6f434c commented Dec 28, 2012

For the record: saying that I don't want bootstrap and setting CONFIG_SHELL allowed me to build previously-failing stdenv-bootstrap gcc on Ubuntu on ARM. And the failure was in installation phase.

I also guess this should improve purity in some cases which seems to be a general good...

As for preHook, I am not sure how can I override it without patching nixpkgs.

Member

viric commented Dec 28, 2012

I think you have to patch nixpkgs, yes. And I'm for it, if it solves any problem.

I'd like to know the details about the failure due to CONFIG_SHELL. I never found a problem related to it.

Member

viric commented Dec 28, 2012

iirc, you try to bootstrap from nixpkgs master with armv5tel... it may be that there is some impurity I unnoticed; the 'stdenv' in nixpkgs master has been built by me only in NixOS. So I had no /usr, and only /bin/sh.

Member

7c6f434c commented Dec 28, 2012

iirc, you try to bootstraps from nixpkgs master with armv5tel... it may be that there is some impurity I unnoticed; the 'stdenv' in nixpkgs master has been built by me only in NixOS. So I had no /usr, and only /bin/sh.

And this is exactly what I am trying to do.

I am waiting to see whether I will get succesful build with two changes, before unrolling either

Member

shlevy commented Apr 4, 2014

@7c6f434c This seems like a decent change, do you want to make up a PR to be part of the pending stdenv merge?

@shlevy shlevy added the enhancement label Apr 5, 2014

@bjornfor bjornfor closed this Aug 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment