fetchFromBitbucket: url split in two when there is a space in rev

[dotlambda]

Issue description

I'm currently writing a derivation for QMapShack:

stdenv.mkDerivation rec {
  name = "QMapShack-${version}";
  version = "1.9.1";

  src = fetchFromBitbucket {
    owner = "maproom";
    repo = "qmapshack";
    rev = "V ${version}";
    sha256 = "1yswdq1s9jjhwb3wfiy3kkiiaqzagw28vjqvl13jxcnmq7y763sr";
  };
}

The important part is that rev = "V 1.9.1" (with a space).
When I try to build this package, two urls are downloaded:

trying https://bitbucket.org/maproom/qmapshack/get/V
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 

trying 1.9.1.tar.gz

I tried to find an error in fetchFromBitbucket, fetchzip and fetchurl but I really have no idea where the url is split in two.

[FRidh]

I think $urls should be quoted at https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchurl/builder.sh#L85

[dotlambda]

Then it should also be quoted at line 126.
But I'm not sure if that works fine if there are really multiple urls.
Also, this leads to another error:

trying  https://bitbucket.org/maproom/qmapshack/get/V 1.9.1.tar.gz
curl: (1) Protocol " https" not supported or disabled in libcurl

Because of the line urls2="$urls2 $url" the url now seems to contain a space at the front.

PS: I've been able to circumvent the problem by using rev = "V%20${version}";.

[Ekleog]

(triage) this is still happening as of now, though the precise example from the first post appears to somehow be cached and one needs to change the hash to see the download attempts.

[stale]

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
2. Ask on the NixOS Discourse.
3. Ask on the #nixos channel on irc.freenode.net.

[lolbinarycat]

trivially fixed by replacing pkgs/build-support/fetchbitbucket/default.nix:8 with url = "https://bitbucket.org/${owner}/${repo}/get/${lib.strings.escapeURL rev}.tar.gz";

however, the original repo seems to no longer exist, so i'm not sure how much merit this has

[tetov]

I was looking into this (to clear off some issue marked trivial) but since the original repo this was needed for is gone I need to find some other repo with whitespace in its rev. Please let me know if you know of any.

[dotlambda]

@tetov Create your own.

[tetov]

@dotlambda: Didn't think that far.

• git stops me from creating branch or tag with spaces, or even a ref/notes/{,custom}
• the REST api doesn't accept spaces
• they have sunset mercurial so I can't use that either

A rev with whitespace in it must have been created with mercurial..

I could create a branch named "tag%20with%20spaces" however and that gets us a 404.. And lib.strings.escapeURL fixes that..