New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube 0.22.1 (and greater?) doesn't build on Darwin due to hyperkit #30133

Closed
edude03 opened this Issue Oct 5, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@edude03
Contributor

edude03 commented Oct 5, 2017

Issue description

As the title says, building minikube from source fails on High Sierra (OSX 10.13) due to not being able to find the vmnet/vmnet.h header

You'll get output such as

# k8s.io/minikube/vendor/github.com/zchee/go-vmnet
go/src/k8s.io/minikube/vendor/github.com/zchee/go-vmnet/vmnet.go:9:10: fatal error: 'vmnet/vmnet.h' file not found
#include <vmnet/vmnet.h>
         ^~~~~~~~~~~~~~~
1 error generated.
...
ld: warning: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation, ignoring unexpected dylib file
...
builder for ‘/nix/store/7xwsx17gcabbm8zsi60b03smknjfg4j2-minikube-0.22.2.drv’ failed with exit code 1
error: build of ‘/nix/store/7xwsx17gcabbm8zsi60b03smknjfg4j2-minikube-0.22.2.drv’ failed

### Steps to reproduce

Build minikube 0.22.2


## Technical details
  • System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
  • Nix version: (run nix-env --version)
  • Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
  • Sandboxing enabled: (run grep build-use-sandbox /etc/nix/nix.conf)
@copumpkin

This comment has been minimized.

Member

copumpkin commented Oct 8, 2017

Those headers aren't supposed to be impure so this is weird, but I guess they're semi-impure so that could explain it.

I probably won't have time to take a look for a bit, but it seems like as long as Hydra's builders stay on pre-10.13 this shouldn't cause most users too many issues unless they're on a revision that Hydra hasn't built yet.

@periklis

This comment has been minimized.

Contributor

periklis commented Nov 15, 2017

i am currently working on an experiment to package zchee/docker-machine-driver-xhyve and run in the same issue on 10.12.6. Maybe i can fix this issue.

@copumpkin

This comment has been minimized.

Member

copumpkin commented Nov 15, 2017

You shouldn't need that driver anymore in the latest minikube, since they pulled xhyve support into the main codebase

@periklis

This comment has been minimized.

Contributor

periklis commented Nov 15, 2017

i am experimenting to use the driver as an independent alternative to run my docker-daemon and get rid of docker-for-mac. e.g. Setting up Docker on macOS

@copumpkin

This comment has been minimized.

Member

copumpkin commented Nov 15, 2017

Ah okay 😄

@johbo

This comment has been minimized.

Contributor

johbo commented Nov 19, 2017

Just ran into this issue on OSX 10.12.6.

@copumpkin

This comment has been minimized.

Member

copumpkin commented Nov 19, 2017

a4d7b6a should fix it

@copumpkin copumpkin closed this in a4d7b6a Nov 19, 2017

@johbo johbo referenced this issue Nov 19, 2017

Closed

minikube: Add vmnet as buildInput on darwin #31830

3 of 8 tasks complete
@johbo

This comment has been minimized.

Contributor

johbo commented Nov 19, 2017

Looks correct, I'll check quickly

@johbo

This comment has been minimized.

Contributor

johbo commented Nov 19, 2017

yep, works for me™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment