New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package set: normalize all attribute names #49691

Open
FRidh opened this Issue Nov 3, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@FRidh
Copy link
Member

FRidh commented Nov 3, 2018

Issue description

The convention in python-packages.nix is to use normalized names although far from every attribute fulfills this requirement.

Having all packages conform will simplify things for automation.

Note that the scope is only the attribute names, and not the pname attributes.

cc @costrouc

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 3, 2018

@costrouc in #49657 (comment)

I know this would require a lot of rebuilds and would possibly break people's configuration but I think that getting all the python package names in nixpkgs normalized is a first step before update automation could be considered.

Fixing the attribute names won't cause any rebuilds, but indeed, it will break people's configuration.

I think that a generated.nix is very doable and a great idea! With correct normalized package naming the only thing this tool this tool misses is extra packages and checkInputs. default.nix would get a lot shorter and simpler to write.

I would be willing to work on normalizing package names.

We should look at adding a test to Nixpkgs so we can enforce this.

@costrouc

This comment has been minimized.

Copy link
Contributor

costrouc commented Nov 3, 2018

Since I am quite new I am not aware of how to add a test to Nixpkgs. Are you suggesting a GrahamcOfBorg check?

Edit: I see the pkgs tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment