Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmediaart: doesn't build on master #53701

Closed
pbogdan opened this issue Jan 9, 2019 · 6 comments

Comments

@pbogdan
Copy link
Member

commented Jan 9, 2019

Issue description

https://hydra.nixos.org/build/86805510/nixlog/2

/cc @jtojnar @hedning

Steps to reproduce

$ nix-build -A libmediaart

Technical details

Nixpkgs master.

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Could you try changing tests/meson.build in the following way?

-     env: 'G_TEST_SRCDIR=' + meson.current_source_dir())
+     env: ['G_TEST_SRCDIR=' + meson.current_source_dir(), 'G_MESSAGES_DEBUG=all'])
@pbogdan

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

Build log with G_MESSAGES_DEBUG=all set - https://gist.github.com/pbogdan/b0f7a959c7aa0c05c53ace66fa80bc71
The test suite does seem to work without sandboxing enabled but I can't figure out why that might be.

@hedning

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Looks like an upstream issue with glib-2.58.2: https://gitlab.gnome.org/GNOME/glib/issues/1645

I'm testing the proposed fix at the moment: https://gitlab.gnome.org/GNOME/glib/merge_requests/578/diffs

@hedning

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Yep, that fixes the problem.

Though glib is a pretty big rebuild, so not sure if we want to apply a stop gap to libmediaart on master too? (as this blocks nixos-unstable due to gnome-music).

hedning added a commit to hedning/nixpkgs that referenced this issue Jan 9, 2019
In particular this fixes the libmediaarts tests.

closes NixOS#53701
hedning added a commit to hedning/nixpkgs that referenced this issue Jan 9, 2019
In particular this fixes the libmediaart tests.

closes NixOS#53701
@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Hmm, not sure why I read Darwin instead of master. Yes, temporarily disabling the checks makes sense to me.

@hedning

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

The stop gap is in master now, and the glib fix is in staging.

@hedning hedning closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.