Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Hydra evaluation errors gracefully #6561

Closed
domenkozar opened this issue Feb 25, 2015 · 5 comments
Closed

Handle Hydra evaluation errors gracefully #6561

domenkozar opened this issue Feb 25, 2015 · 5 comments
Labels
0.kind: enhancement 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: documentation Meta-discussion about documentation and its workflow

Comments

@domenkozar
Copy link
Member

Currently there are two problems that occur if a package fails to evaluate (on purpose):

a) "broken" or "disabled" package is not propagated to reverse dependencies. If a package A depends on package B and B is marked as broken/disabled,
package A will still be evaluate-able and will result in an evaluation error

b) evaluation errors spams the hydra error tab page


Proposal to fix b)

  • provide high-level throw function that prefixes the error message with something that will indicate the error is supposed to happen
  • document the function
  • make sure Python and meta.broken uses it
  • handle such errors in pkgs/top-level/release-lib.nix by regexing them out from the output

Previous discussions:

@zimbatm
Copy link
Member

zimbatm commented Apr 9, 2016

It's still an issue right ?

@joachifm
Copy link
Contributor

joachifm commented Apr 9, 2016

Looks like it

@zimbatm
Copy link
Member

zimbatm commented Apr 9, 2016

It's not the same but similar to madjar/nox#40. It would be nice to have a function that filters out all the invalid builds recursively from a set.

@edolstra edolstra changed the title Handle evaluation errors gracefully Handle Hydra evaluation errors gracefully Apr 11, 2016
@Profpatsch
Copy link
Member

@domenkozar iirc this discussion moved to other issues, would it bother you closing this instance?

@stale
Copy link

stale bot commented Jun 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2020
@Artturin Artturin added 6.topic: documentation Meta-discussion about documentation and its workflow and removed old-label: documentation labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: documentation Meta-discussion about documentation and its workflow
Projects
None yet
Development

No branches or pull requests

5 participants