Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 #100009

Merged
merged 4 commits into from Oct 14, 2020

Conversation

@austinbutler
Copy link
Contributor

@austinbutler austinbutler commented Oct 8, 2020

Motivation for this change

Build was missing dependencies. Will backport for 20.09.

https://hydra.nixos.org/build/127625743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@austinbutler austinbutler changed the title Google cloud asset fix python3Packages.google_cloud_asset: fix build Oct 8, 2020
@ofborg ofborg bot requested a review from costrouc Oct 8, 2020
@austinbutler austinbutler force-pushed the google-cloud-asset-fix branch from 80983ca to e1da0e5 Oct 9, 2020
@austinbutler austinbutler requested a review from jonringer Oct 12, 2020
@austinbutler austinbutler force-pushed the google-cloud-asset-fix branch from e1da0e5 to af95a72 Oct 13, 2020
@austinbutler austinbutler changed the title python3Packages.google_cloud_asset: fix build python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 Oct 13, 2020
@austinbutler austinbutler force-pushed the google-cloud-asset-fix branch from af95a72 to f99d700 Oct 13, 2020
@ofborg ofborg bot requested a review from ruuda Oct 13, 2020
ruuda
ruuda approved these changes Oct 13, 2020
Copy link
Contributor

@ruuda ruuda left a comment

Thanks for fixing the libcst tests! Those changes look good to me.

I glossed over the other changes as well and those look good to me too, but I am not an expert in Python packaging.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100009 1

10 packages built:
  • python37Packages.google-cloud-access-context-manager
  • python37Packages.google-cloud-org-policy
  • python37Packages.google_cloud_asset
  • python37Packages.google_cloud_dataproc
  • python37Packages.libcst
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-org-policy
  • python38Packages.google_cloud_asset
  • python38Packages.google_cloud_dataproc
  • python38Packages.libcst

@jonringer jonringer merged commit 326a5f7 into NixOS:master Oct 14, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f99d700"; rev="f99d700e2dbe9e4cc86688ce684faa54b96dc5c6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@austinbutler austinbutler deleted the google-cloud-asset-fix branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants