Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel_1: fix build on darwin #100012

Merged
merged 1 commit into from Oct 10, 2020
Merged

bazel_1: fix build on darwin #100012

merged 1 commit into from Oct 10, 2020

Conversation

@tricktron
Copy link
Contributor

@tricktron tricktron commented Oct 8, 2020

Motivation for this change

ZHF: #97479
cc: @NixOS/nixos-release-managers

Uses clang_8 instead of clang_7 on darwin to fix thread_local error.

The build runs through successfully but bazel fails to start the server:

Build successful! Binary is here: /private/tmp/nix-build-bazel-1.2.1.drv-0/bazel_src/output/bazel
Extracting Bazel installation...
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".
installing
post-installation fixup
patching script interpreter paths in /nix/store/y6sdsgns53cirjwplyl7gpsdrvhkgjjb-bazel-1.2.1
running install tests
$TEST_TMPDIR defined: output root default is '/private/tmp/nix-build-bazel-1.2.1.drv-0' and max_idle_secs default is '15'.
Extracting Bazel installation...
Starting local Bazel server and connecting to it...

Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/private/tmp/nix-build-bazel-1.2.1.drv-0/_bazel_nixbld1/734e1a1fb0129200ec302097141b437e/server/jvm.out')

Could anybody with more knowledge about bazel jump in and help me finish this pr?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tricktron tricktron requested a review from Profpatsch as a code owner Oct 8, 2020
@ofborg ofborg bot added the 6.topic: darwin label Oct 8, 2020
@tricktron tricktron marked this pull request as draft Oct 8, 2020
@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 8, 2020

@risicle You are an avid contributor who has a Mac machine. Could you try to build this and see if you get the same error?

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Oct 8, 2020

I haven’t tried it out, but the changes look benign for non-MacOS. The failing test must be unrelated.

@Profpatsch Profpatsch mentioned this pull request Oct 8, 2020
3 of 10 tasks complete
@risicle
Copy link
Contributor

@risicle risicle commented Oct 8, 2020

WFM macos 10.14.

@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 8, 2020

@risicle Without any errors?

@risicle
Copy link
Contributor

@risicle risicle commented Oct 8, 2020

No errors.

@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 8, 2020

Nice, I'll guess this is then ready to merge too😃

@tricktron tricktron marked this pull request as ready for review Oct 8, 2020
@risicle
Copy link
Contributor

@risicle risicle commented Oct 8, 2020

Your commit message still has all the

Could anybody with more knowledge about bazel jump in and help me finish this pr?

stuff in it.

Thibault Gagnaux
Use clang_8 instead of clang_7 on darwin to fix thread_local storage error.
@tricktron tricktron force-pushed the tricktron:fix-bazel_1-darwin branch from 5360bc9 to f7aafe6 Oct 10, 2020
@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 10, 2020

Your commit message still has all the

Could anybody with more knowledge about bazel jump in and help me finish this pr?

stuff in it.

@risicle Ah yes I forgot about that. Thanks for reminding me. I rebased and edited the commit message.

@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

This seems sensible. I think normally people would try and keep the stdenv switcharoo up in all-packages.nix, but I can see how that would make things weird here what with needing to be able to directly reference llvmPackages_8...

@risicle risicle merged commit 96e42b0 into NixOS:master Oct 10, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
bazel_1, bazel_1.passthru.tests on aarch64-linux Success
Details
bazel_1, bazel_1.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7aafe6"; rev="f7aafe6345f6d2fa5db8d6b23f7cf9315d73f67d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@tricktron tricktron deleted the tricktron:fix-bazel_1-darwin branch Oct 10, 2020
@tricktron tricktron mentioned this pull request Oct 10, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.