Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] python38Packages.importlib-metadata: return null #100017

Closed
wants to merge 1 commit into from

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 8, 2020

Motivation for this change

This is a backport, packages are discouraged not to use it

wondering if this is feasible, it's about a 280K closure size saving in a few thousand packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is a backport, packages are discouraged not to use it
@FRidh
Copy link
Member

@FRidh FRidh commented Oct 20, 2020

We should avoid setting something to null, but it is however convenient/pragmatic.

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 21, 2020

The main issue is there's an import mismatch "importlib.metadata" vs "importlib_metada" (backport)

The saving is only ~280K, but it would still be nice to get rid of it.

@Vonfry
Copy link
Member

@Vonfry Vonfry commented Nov 27, 2020

This package is old, should we update it as well?

pypi: url

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 27, 2020

This package is old, should we update it as well?

We should probably do that as part of a large update.

cc @FRidh did you want to do a python-unstable bump?

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 27, 2020

cc @FRidh did you want to do a python-unstable bump?

"want" isn't how I would put it, but yes, I think it is about time again.

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 27, 2020

"want" isn't how I would put it, but yes, I think it is about time again.

Did you want me to do it? Just so that the process is able to be done by more than one person?

@FRidh FRidh added this to To do in Python batch upgrade Dec 2, 2020
@FRidh FRidh added this to the 21.05 milestone Mar 20, 2021
@FRidh
Copy link
Member

@FRidh FRidh commented Mar 24, 2021

cc @FRidh did you want to do a python-unstable bump?

#117452

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented May 22, 2021

importlib-metadata has been updated to backport 3.10 behavior. this is no longer relevant

@jonringer jonringer closed this May 22, 2021
Python batch upgrade automation moved this from To do to Done May 22, 2021
@jonringer jonringer deleted the importlib-metadata-null branch May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants