Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ Added nb #100019

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat/ Added nb #100019

wants to merge 3 commits into from

Conversation

@CreativeCactus
Copy link

@CreativeCactus CreativeCactus commented Oct 8, 2020

Motivation for this change

Adding nb to nixpkgs, since I already wrote a derivation.

Very small change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@fadenb fadenb left a comment

Other than the two inline comments LGTM (none of them seems like a real issue)

pkgs/tools/misc/nb/default.nix Outdated Show resolved Hide resolved
src = fetchgit {
url = "https://github.com/xwmx/nb.git";
rev = version;
sha256 = "LXgLzO+rPCalkWBF79U2Y8r+wtTfSMMuHRYlT/wKd3g=";
};
Copy link
Member

@fadenb fadenb Oct 8, 2020

I believe currently fetchFromGitHub is preferred over `fetchgit if no submodules are needed?

Copy link
Author

@CreativeCactus CreativeCactus Oct 8, 2020

Interesting, where should I look to find conventions like this?
I don't have time to fix this up right now, but probably will this week (otherwise updates welcome).

fadenb
fadenb approved these changes Oct 12, 2020
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please use pname and version and replace let in with rec. Also update the PR title and commit title to fit the contributing guide.

@stale
Copy link

@stale stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants