Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo: 1.8.31p1 -> 1.9.3p1 + adding myself as maintainer #100024

Merged
merged 3 commits into from Oct 10, 2020

Conversation

@delroth
Copy link
Contributor

@delroth delroth commented Oct 8, 2020

Motivation for this change

sudo in nixpkgs is currently lagging several versions behind, and it seems to be solely due to maintainer bandwidth (no reply on the last two pull requests bumping the package, #93100 and #88768). We're currently stuck on a release from 5 months ago, which isn't ideal for such a core package.

This PR bumps to the newest release, and adds myself as a maintainer for sudo so I can help with keeping this up to date in the future.

Closes #93100
Closes #88768

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
delroth added 3 commits Oct 8, 2020
@ajs124
ajs124 approved these changes Oct 9, 2020
@samueldr
Copy link
Member

@samueldr samueldr commented Oct 10, 2020

Thanks for the upgrade!

@samueldr samueldr merged commit 8d3a7d9 into NixOS:master Oct 10, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb1b32a"; rev="fb1b32adc861d28da63a2c7e0149b0348402418d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sudo, sudo.passthru.tests on aarch64-linux Success
Details
sudo, sudo.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.