Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] pythonPackages.pyotp: fix tests #100025

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Oct 8, 2020

(cherry picked from commit ae23d0b)

ZHF: #97479

PR to master: #100023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit ae23d0b)
@IvarWithoutBones IvarWithoutBones changed the title pythonPackages.pyotp: fix tests [20.09] pythonPackages.pyotp: fix tests Oct 8, 2020
@ofborg ofborg bot requested a review from dotlambda Oct 8, 2020
@risicle
Copy link
Contributor

@risicle risicle commented Oct 8, 2020

I generally wouldn't open a backport PR until after the original is merged as someone may choose to do a rebase-merge, which would mean your original commit id wouldn't make it in.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100025 1

4 packages built:
  • home-assistant
  • python27Packages.pyotp
  • python37Packages.pyotp
  • python38Packages.pyotp

@jonringer jonringer merged commit 5ed3b07 into NixOS:release-20.09 Oct 11, 2020
16 checks passed
@risicle
Copy link
Contributor

@risicle risicle commented Oct 11, 2020

This hasn't been merged to master yet.

@IvarWithoutBones IvarWithoutBones deleted the pyotp-fix-backport branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants