Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ikiwiki fixes and update #100033

Merged
merged 4 commits into from Nov 27, 2020
Merged

Ikiwiki fixes and update #100033

merged 4 commits into from Nov 27, 2020

Conversation

@wentasah
Copy link
Contributor

@wentasah wentasah commented Oct 8, 2020

Motivation for this change

Ikiwiki, as currently shipped, fails to compile my wikies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): before: 580.4M, after: 587.7M
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested execution of the ikiwiki binary only.

wentasah added 4 commits Oct 8, 2020
IkiWiki's highlight plugin requires this.

Note that the current highlight version (3.57) is not compatible with
ikiwiki version in nixpkgs. This will be fixed in the next commit.
The line-continuation backslash should not be a part of optional
string because it can lead to errors like this:

    /nix/store/333six1faw9bhccsx9qw5718k6b1wiq2-stdenv-linux/setup: line 90: --prefix: command not found
    builder for '/nix/store/lb07r900fpg7r1555zpf0j8n1n7g3wlx-ikiwiki-3.20200202.3.drv' failed with exit code 127
Without this, the rst plugin complains as follows:

    cannot import docutils.core

Also, python3 is needed for the rst plugin to work.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100033 run on x86_64-linux 1

1 package built:
  • ikiwiki

@SuperSandro2000 SuperSandro2000 merged commit a005d72 into NixOS:master Nov 27, 2020
19 checks passed
@wentasah wentasah deleted the ikiwiki branch Nov 29, 2020
@wentasah
Copy link
Contributor Author

@wentasah wentasah commented Nov 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants