Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5.qtwebengine: Sessions restore patch #100041

Closed
wants to merge 1 commit into from

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 8, 2020

Per #99456 (comment)

cc @ttuegel .

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar doronbehar requested a review from ttuegel as a code owner Oct 8, 2020
@doronbehar doronbehar mentioned this pull request Oct 8, 2020
10 tasks
@ofborg ofborg bot requested a review from matthewbauer Oct 8, 2020
@doronbehar doronbehar changed the base branch from staging to master Oct 8, 2020
@doronbehar doronbehar force-pushed the pkg/qt/webengine-patch branch from 13506ca to 2547b3d Oct 8, 2020
@doronbehar doronbehar requested review from FRidh and jonringer as code owners Oct 8, 2020
@doronbehar doronbehar force-pushed the pkg/qt/webengine-patch branch from 2547b3d to 6ef704c Oct 8, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Oct 8, 2020

Targeting PR to master.

@The-Compiler
Copy link
Contributor

@The-Compiler The-Compiler commented Oct 12, 2020

Note this isn't a security patch - it patches crashes happening with Qt 5.15.1 which make it almost unusable otherwise, but they are not security related.

What I meant in #99456 (comment) is that it's a bad idea for the qutebrowser package to depend on Qt 5.14 instead of 5.15.

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Oct 13, 2020

it patches crashes happening with Qt 5.15.1

Now I notice our qt5.15 is qt5.15.0 but the patch applies to it as well. It's still good to apply it right?

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Oct 13, 2020

Fixed the commit message.

@doronbehar doronbehar force-pushed the pkg/qt/webengine-patch branch from 6ef704c to b206142 Oct 13, 2020
@The-Compiler
Copy link
Contributor

@The-Compiler The-Compiler commented Oct 13, 2020

Now I notice our qt5.15 is qt5.15.0 but the patch applies to it as well. It's still good to apply it right?

Surely doesn't hurt. I don't know which change between Qt 5.15.0 and .1 triggered the issue.

@doronbehar doronbehar changed the title qt5.qtwebengine: Security patch qt5.qtwebengine: Sessions restore patch Oct 14, 2020
@gebner gebner mentioned this pull request Oct 31, 2020
10 tasks
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Nov 5, 2020

Closed in favor of #102216 .

@doronbehar doronbehar closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants