Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oberon-risc-emu: init at 2020-08-18 #100042

Merged
merged 1 commit into from Jan 10, 2021

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones left a comment

A few suggestions, but functionality wise this PR LGTM 👍

Binary builds, and successfully displays the help section.

Result of nixpkgs-review pr 100042 1

1 package built:
  • oberon-risc-emu

@siraben siraben force-pushed the oberon-risc-emu-init branch 2 times, most recently from 92119b8 to 006b656 Oct 9, 2020
@siraben siraben changed the title oberon-risc-emu: init at unstable-2020-08-18 oberon-risc-emu: init at 2020-08-18 Oct 9, 2020
@siraben
Copy link
Member Author

@siraben siraben commented Oct 10, 2020

@siraben siraben force-pushed the oberon-risc-emu-init branch 2 times, most recently from 1e1b758 to d0fd082 Nov 27, 2020
@siraben siraben requested a review from SuperSandro2000 Jan 5, 2021
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 7, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 100042 run on x86_64-linux 1

1 package built:
  • oberon-risc-emu

@siraben siraben force-pushed the oberon-risc-emu-init branch from 4535e08 to bf91623 Jan 8, 2021
@siraben siraben requested a review from SuperSandro2000 Jan 9, 2021
@SuperSandro2000 SuperSandro2000 merged commit be660e2 into NixOS:master Jan 10, 2021
19 checks passed
@siraben siraben deleted the oberon-risc-emu-init branch Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants