Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 0.45.2 -> 0.46.0 #100043

Merged
merged 1 commit into from Oct 28, 2020
Merged

starship: 0.45.2 -> 0.46.0 #100043

merged 1 commit into from Oct 28, 2020

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Oct 8, 2020

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.46.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 9, 2020

Fails with the following test failures for me:

starship> failures:
starship> ---- modules::golang::tests::folder_with_glide_yaml stdout ----
starship> thread 'modules::golang::tests::folder_with_glide_yaml' panicked at 'assertion failed: `(left == right)`
starship>   left: `Some("via \u{1b}[1;36m🐹 v1.12.1\u{1b}[0m ")`,
starship>  right: `None`', src/modules/golang.rs:162:9
starship> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
starship> failures:
starship>     modules::golang::tests::folder_with_glide_yaml
starship> test result: FAILED. 449 passed; 1 failed; 25 ignored; 0 measured; 10 filtered out
starship> error: test failed, to rerun pass '--lib'
starship> builder for '/nix/store/rqx5mhvr897i1n13rvkx9q29nd8xpk3f-starship-0.46.0.drv' failed with exit code 101

@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 9, 2020

@Ma27 on NixOS?

@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 9, 2020

Result of nixpkgs-review pr 100043 1

1 package built:
  • starship

Copy link
Member

@davidtwco davidtwco left a comment

Result of nixpkgs-review pr 100043 1

1 package built:
  • starship

@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 9, 2020

@bbigras yes.

@marsam marsam force-pushed the update-starship branch from 3af4263 to 00e8767 Oct 13, 2020
@marsam marsam requested a review from Ma27 Oct 13, 2020
@ofborg ofborg bot requested a review from davidtwco Oct 13, 2020
@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 13, 2020

Is there anything wrong with disabling this test?

@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 13, 2020

Is there anything wrong with disabling this test?

Maybe we could but could you also run the tests directly on the upstream repo and fill an issue upstream?

git clone https://github.com/starship/starship.git
cd starship
nix-shell -p cargo
cargo test

@marsam marsam force-pushed the update-starship branch from 00e8767 to 0367125 Oct 25, 2020
@marsam
Copy link
Contributor Author

@marsam marsam commented Oct 27, 2020

Is there anything wrong with disabling this test?

the test itself looks ordinary, and I'm not sure why it's failing for you.
could you please give the following a try?

--- i/pkgs/tools/misc/starship/default.nix
+++ w/pkgs/tools/misc/starship/default.nix
@@ -33,13 +33,14 @@ rustPlatform.buildRustPackage rec {
 
   cargoSha256 = "1smz7084ppz79p8migpy0cqp6azf7sixv9ga65l2f3zfna7kbk78";
 
+  cargoParallelTestThreads = false;
+
   checkFlags = [
     "--skip=directory_in_home"
     "--skip=home_directory"
     "--skip=directory_in_root"
     "--skip=truncation_symbol_not_truncated_home"
     "--skip=truncation_symbol_truncated_home"
-    "--skip=folder_with_glide_yaml"
     "--skip=shows_multiple_tfms"
     "--skip=shows_pinned_in_project_below_root_with_global_json"
   ];

@teto
Copy link
Contributor

@teto teto commented Oct 27, 2020

dunno if that helps but current release is https://github.com/starship/starship/tree/v0.46.2

@marsam marsam merged commit b69f140 into NixOS:master Oct 28, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
starship, starship.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0367125"; rev="0367125b170df2a2999537ffbb083583617ad8e4"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
starship, starship.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
starship, starship.passthru.tests on x86_64-linux Success
Details
@marsam marsam deleted the update-starship branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants