Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packetdrill: 1.0 -> unstable-2020-08-22, fix build #100044

merged 1 commit into from Oct 8, 2020


Copy link

@risicle risicle commented Oct 8, 2020

Motivation for this change

ZHF: #97479

Build was broken by the glibc 2.30 switch. Upstream repo doesn't seem to have regular releases or tagging, but the latest master does build against glibc 2.30 and has grown cmake build support, which works without having to do the funny patching previously done by this package.

Still have to cobble together our own installPhase though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
dmjio approved these changes Oct 8, 2020
@risicle risicle merged commit 8484c44 into NixOS:master Oct 8, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants