New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hostctl: init at 1.0.14 #100048
hostctl: init at 1.0.14 #100048
Conversation
Result of 1 package built:- hostctl
|
This comment has been minimized.
This comment has been minimized.
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
This comment has been minimized.
This comment has been minimized.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
init: hostctl at 1.0.14
commit message should be hostctl: init at 1.0.14
instead (package name at beginning)
Would also be ideal if the Merge commit was removed and the branch was rebased instead |
7af285a
to
2e7c621
Compare
Formalities adressed. Good to merge. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
@GrahamcOfBorg eval Not sure why this isn't happening. Maybe it has something to do with targeting staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Note this got merged into staging-next. |
That was intentional. Context: #100048 (comment) |
Motivation for this change
Add hostmanagement to devshell numtide/devshell#28
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)