Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostctl: init at 1.0.14 #100048

Merged
merged 1 commit into from Oct 30, 2020
Merged

hostctl: init at 1.0.14 #100048

merged 1 commit into from Oct 30, 2020

Conversation

@blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Oct 8, 2020

Motivation for this change

Add hostmanagement to devshell numtide/devshell#28

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@blaggacao blaggacao changed the title Da package hostctl init: hostctl at 1.0.14 Oct 8, 2020
@blaggacao
Copy link
Contributor Author

@blaggacao blaggacao commented Oct 8, 2020

Result of nixpkgs-review pr 100048 1

1 package built:
- hostctl
  • checked hostcl --help

@blaggacao

This comment has been hidden.

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@blaggacao

This comment has been hidden.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 9, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/333

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 10, 2020

Result of nixpkgs-review pr 100048 1

1 package built:
  • hostctl

Copy link
Contributor

@06kellyjac 06kellyjac left a comment

LGTM 👍

Copy link
Contributor

@xfix xfix left a comment

init: hostctl at 1.0.14 commit message should be hostctl: init at 1.0.14 instead (package name at beginning)

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 12, 2020

Would also be ideal if the Merge commit was removed and the branch was rebased instead

@blaggacao
Copy link
Contributor Author

@blaggacao blaggacao commented Oct 26, 2020

Formalities adressed. Good to merge.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 26, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/263

@timokau
Copy link
Member

@timokau timokau commented Oct 29, 2020

@GrahamcOfBorg eval

Not sure why this isn't happening. Maybe it has something to do with targeting staging.

Copy link
Member

@timokau timokau left a comment

Thank you!

@timokau timokau merged commit ae01350 into NixOS:staging-next Oct 30, 2020
19 checks passed
@blaggacao blaggacao deleted the da-package-hostctl branch Oct 30, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Oct 30, 2020

Note this got merged into staging-next.

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 30, 2020

That was intentional. Context: #100048 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment