Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] packetdrill: 1.0 -> unstable-2020-08-22, fix build #100049

merged 1 commit into from Oct 11, 2020


Copy link

@risicle risicle commented Oct 8, 2020

Motivation for this change

ZHF: #97479

Backport of #100044

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
also switch to cmake build

(cherry picked from commit 87fad4d)
Copy link
Contributor Author

@risicle risicle commented Oct 8, 2020

@ofborg build packetdrill

Copy link

@jonringer jonringer left a comment


Result of nixpkgs-review pr 100049 1

1 package built:
  • packetdrill

@jonringer jonringer merged commit c4ea77f into NixOS:release-20.09 Oct 11, 2020
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants