Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.sip: do not build tools for non-default sip module #100050

Closed
wants to merge 1 commit into from

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Oct 8, 2020

This ensures that the default sip and alternative sips do not have common files.

Rebased #52968.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This ensures that the default sip and alternative sips do not have common files.
@FRidh FRidh requested a review from jonringer as a code owner Oct 8, 2020
@FRidh
Copy link
Member Author

@FRidh FRidh commented Oct 8, 2020

I guess with this approach we no longer need the namespaces hack.

@FRidh FRidh requested review from doronbehar and orivej-nixos Oct 8, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 8, 2020

Sorry @FRidh but I don't get a thing from what's going on here. I only noticed that sip could be updated (#99936) and that it needed a simple update patch for pyqt5.15 (#99933 ).

@FRidh
Copy link
Member Author

@FRidh FRidh commented Oct 10, 2020

According to the docs this is how we should build https://www.riverbankcomputing.com/static/Docs/PyQt5/building_with_configure.html.

However, closing this in favor of the (not yet finished) upgrade in #100129.

@FRidh FRidh closed this Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.