Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] pythonPackages.sievelib: fix build by adding patch #100054

Merged
merged 1 commit into from Oct 9, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 8, 2020

Motivation for this change

ZHF: #97479

Backport of #98016

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
this fixes installation with newer pip versions

also give a name to an existing patch

(cherry picked from commit 4d111fd)
@risicle risicle requested review from FRidh and jonringer as code owners Oct 8, 2020
@risicle risicle changed the title pythonPackages.sievelib: fix build by adding patch [20.09] pythonPackages.sievelib: fix build by adding patch Oct 8, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100054 1

3 packages built:
  • python27Packages.sievelib
  • python37Packages.sievelib
  • python38Packages.sievelib

@jonringer jonringer merged commit 99fa761 into NixOS:release-20.09 Oct 9, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants