Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dnsdist: use upstream systemd unit #100060

Merged
merged 1 commit into from Oct 12, 2020
Merged

nixos/dnsdist: use upstream systemd unit #100060

merged 1 commit into from Oct 12, 2020

Conversation

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse aanderse force-pushed the dnsdist branch 2 times, most recently from 86af69b to feb52c0 Oct 9, 2020
@aanderse aanderse marked this pull request as ready for review Oct 9, 2020
@aanderse aanderse requested a review from disassembler Oct 9, 2020
@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 9, 2020

ping @ShaRose

@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 10, 2020

@ofborg eval

@aanderse aanderse requested a review from dasJ Oct 11, 2020
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 11, 2020

@aanderse See #81138, it does ignore the [Install] section 😦

@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 11, 2020

Thanks for the info @worldofpeace!

@aanderse aanderse requested a review from rnhmjoj Oct 12, 2020
@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 12, 2020

@rnhmjoj with dnsdist versions 1.5.x and above (which is currently in our master branch) this should work now, as far as I can tell from reading documentation. Does this PR work for you now?

nixos/modules/services/networking/dnsdist.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Looks good now!

@rnhmjoj rnhmjoj merged commit 9b6fc07 into NixOS:master Oct 12, 2020
16 checks passed
@aanderse aanderse deleted the dnsdist branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants