Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerdns: update configure flags #100061

Merged
merged 3 commits into from Oct 13, 2020
Merged

powerdns: update configure flags #100061

merged 3 commits into from Oct 13, 2020

Conversation

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 8, 2020

Motivation for this change

https://doc.powerdns.com/authoritative/appendices/compiling.html

The PowerDNS Authoritative Server can link with libsodium to support ed25519 (DNSSEC algorithm 15). To detect libsodium, use the --with-libsodium configure option.

Changed in version 4.2.0: This option was previously --enable-libsodium

https://doc.powerdns.com/authoritative/appendices/crypto-export.html

Optionally, PowerDNS can link in a copy of the open source Botan cryptographic library. Starting with 4.2.0, linking in Botan is no longer possible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse aanderse marked this pull request as ready for review Oct 9, 2020
@aanderse aanderse requested review from vcunat, Mic92 and rnhmjoj Oct 9, 2020
@samueldr

This comment has been hidden.

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 10, 2020

There is NixOS tests for this. Can you add it to the passthru.tests for ofBorg?

@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 10, 2020

@ofborg eval

@aanderse aanderse merged commit 5872b64 into NixOS:master Oct 13, 2020
19 of 20 checks passed
@aanderse aanderse deleted the powerdns branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants