Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicad #100065

Merged
merged 2 commits into from Oct 10, 2020
Merged

Kicad #100065

merged 2 commits into from Oct 10, 2020

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 9, 2020

Motivation for this change

Modifies the kicad update script to use gitlab and updates kicad-unstable.

Things done

kicad-unstable now requires gtk3 as a build input to compile. I've also reformatted the files to have one parameter per line and one build input per line.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@matthuszagh matthuszagh requested a review from evils Oct 9, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 9, 2020

There's a trailing space in update.sh. Other eval error has nothing to do with you.

matthuszagh added 2 commits Oct 9, 2020
Kicad libraries are now hosted on gitlab instead of github.
base.nix requires gtk3 to compile
@matthuszagh matthuszagh force-pushed the matthuszagh:kicad branch from 20e2c3f to 104aca9 Oct 9, 2020
@matthuszagh
Copy link
Contributor Author

@matthuszagh matthuszagh commented Oct 9, 2020

@doronbehar trailing whitespace should now be fixed.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 10, 2020

@ofborg eval

@doronbehar doronbehar merged commit 967a01f into NixOS:master Oct 10, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="104aca9"; rev="104aca941a7cf0f301ebc16c5da66bf039f990b6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@matthuszagh matthuszagh deleted the matthuszagh:kicad branch Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.