Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams: -> #100073

merged 1 commit into from Oct 17, 2020

teams: -> #100073

merged 1 commit into from Oct 17, 2020


Copy link

@devhell devhell commented Oct 9, 2020

Motivation for this change


Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@doronbehar doronbehar commented Oct 9, 2020

Copy link
Contributor Author

@devhell devhell commented Oct 13, 2020

liff approved these changes Oct 14, 2020
Copy link

@stigtsp stigtsp left a comment


Matches latest upstream version

Did basic test

@stigtsp stigtsp merged commit 1bae8e2 into NixOS:master Oct 17, 2020
18 of 19 checks passed
@devhell devhell deleted the update-msteams branch Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants