Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidStudioPackages.stable: 4.0.1.0 -> 4.0.2.0 #100076

Merged
merged 1 commit into from Oct 10, 2020
Merged

androidStudioPackages.stable: 4.0.1.0 -> 4.0.2.0 #100076

merged 1 commit into from Oct 10, 2020

Conversation

@ghost
Copy link

@ghost ghost commented Oct 9, 2020

Motivation for this change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ghost
Copy link
Author

@ghost ghost commented Oct 9, 2020

Tested with a clean build and running of a medium sized application in the emulator.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 9, 2020

@ghost
Copy link
Author

@ghost ghost commented Oct 10, 2020

@doronbehar Is there something up with the ofborg bot? That error log does not seem related to this commit.

warning: ignoring the user-specified setting 'restrict-eval', because it is a restricted setting and you are not a trusted user
error: while evaluating 'callPackageWith' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:117:35, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/all-packages.nix:16632:15:
while evaluating 'makeOverridable' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:67:24, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:121:8:
anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/servers/mediatomb/default.nix:1:1 called without required argument 'spidermonkey', at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:69:16

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 10, 2020

There have been some issues accross all of nixpkgs' PRs. Now they are solved.

@ofborg eval

@ghost
Copy link
Author

@ghost ghost commented Oct 10, 2020

@primeos primeos merged commit b60f560 into NixOS:master Oct 10, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants