Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidermonkey: drop from all-packages, add to aliases #100089

Merged
merged 1 commit into from Oct 9, 2020

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Oct 9, 2020

Motivation for this change

See #100026 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace merged commit 2023cbe into NixOS:master Oct 9, 2020
2 of 4 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 9, 2020

Thanks for looking out @mkg20001

@@ -661,6 +661,8 @@ mapAliases ({
youtubeDL = youtube-dl; # added 2014-10-26
zdfmediathk = mediathekview; # added 2019-01-19
gnome_user_docs = gnome-user-docs; # added 2019-11-20
# spidermonkey is not ABI upwards-ompatible, so only allow this for nix-shell
spidermonkey = spidermonkey_78; # added 2020-10-09
Copy link
Member

@grahamc grahamc Oct 9, 2020

A brief note that aliases.nix are enabled by default for users of nixpkgs, and their use is only prohibited from within nixpkgs itself. In other words, nix-shell isn't really the determining factor here.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 9, 2020

@mkg20001 @worldofpeace This PR causes eval errors for all PRs now, due to ofborg's "no aliases check". It's the 2nd ofborg eval causing commit this day! (cd1b594)

To do this change properly, you should iterate over all usages of spidermonkey and remove any usage of the alias.

@JohnAZoidberg JohnAZoidberg mentioned this pull request Oct 9, 2020
10 tasks
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 9, 2020

Yeah, ofborg has been... Anyways, we can fix it by just replacing uses of spidermonkey in nixpkgs with the versioned attribute.

doronbehar added a commit that referenced this issue Oct 9, 2020
A fix for #100089 which caused ofborg eval errors on all PRs due to
usage of aliases in couchdb and mediatomb.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 9, 2020

Fixed in 0da82de .

bjornfor
Copy link
Contributor

bjornfor commented on 556ad0d Oct 11, 2020

compatible?

mkg20001
Copy link
Member

mkg20001 commented on 556ad0d Oct 11, 2020

yes 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants