Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: don't use spidermonkey attr #100095

Merged
merged 3 commits into from Oct 9, 2020
Merged

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace deleted the eval-fix branch Oct 9, 2020
@worldofpeace worldofpeace restored the eval-fix branch Oct 9, 2020
@worldofpeace worldofpeace reopened this Oct 9, 2020
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 9, 2020

@doronbehar I believe the versions you used weren't correct for all the couchdb stuff.

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 9, 2020

Oh goodness I've pushed the wrong commit. Don't review yet.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 9, 2020

Actually that's exactly what I wanted to further push now. Running ofborg checks locally right now.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 9, 2020

I'm just about to get supper, sorry to leave you out with this and sorry for the slight mess.

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 9, 2020

I'm just about to get supper, sorry to leave you out with this and sorry for the slight mess.

It's okay. I'd say nixpkgs is the biggest and nicest mess there is 😁

@worldofpeace worldofpeace merged commit b863ef1 into NixOS:master Oct 9, 2020
16 checks passed
@worldofpeace worldofpeace deleted the eval-fix branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants