Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyhton3Packages.ibis-framework: fix tests for pandas 1.1 #100099

merged 1 commit into from Oct 9, 2020


Copy link

@veprbl veprbl commented Oct 9, 2020

Motivation for this change

Fix the build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

cc #97479

Copy link
Member Author

@veprbl veprbl commented Oct 9, 2020

@ofborg ofborg bot requested a review from costrouc Oct 9, 2020
@veprbl veprbl merged commit c42c904 into NixOS:master Oct 9, 2020
17 checks passed
@veprbl veprbl deleted the pr/ibis-framework_fix branch Oct 9, 2020
veprbl added a commit that referenced this issue Oct 9, 2020
@veprbl veprbl restored the pr/ibis-framework_fix branch Dec 1, 2020
@veprbl veprbl deleted the pr/ibis-framework_fix branch Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant