Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Disable VA-API by default #100101

Merged
merged 1 commit into from Oct 10, 2020
Merged

chromium: Disable VA-API by default #100101

merged 1 commit into from Oct 10, 2020

Conversation

@primeos
Copy link
Member

@primeos primeos commented Oct 9, 2020

This is done to avoid driver specific issues and restores the previous
behaviour. Like before video acceleration can be enabled without having
to rebuild Chromium.

Status

Should be fine but my build is still running. Will test this tomorrow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is done to avoid driver specific issues and restores the previous
behaviour. Like before video acceleration can be enabled without having
to rebuild Chromium.
@primeos primeos force-pushed the primeos:chromium branch from 190cbba to 73b67da Oct 9, 2020
@ofborg ofborg bot requested review from thefloweringash and bendlas Oct 9, 2020
@primeos primeos merged commit cde2e10 into NixOS:master Oct 10, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
chromium, chromium.passthru.tests on x86_64-darwin
Details
chromium, chromium.passthru.tests on aarch64-linux Failure
Details
chromium, chromium.passthru.tests on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73b67da"; rev="73b67da1699c7b4581226f877297f235cdbd051e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.