Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc: Mention fontconfig changes in 20.09 RN #100103

Merged
merged 1 commit into from Oct 10, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 9, 2020

Motivation for this change

cc #95765

This is a major change but it should not cause any issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested that docs render correctly
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is a major change but it should not cause any issues.
@jtojnar jtojnar requested review from worldofpeace and jonringer Oct 9, 2020
@worldofpeace worldofpeace added this to the 20.09 milestone Oct 9, 2020
@worldofpeace worldofpeace added this to In progress in 20.09 Blockers via automation Oct 9, 2020
@jtojnar jtojnar mentioned this pull request Oct 9, 2020
6 of 10 tasks complete
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM

20.09 Blockers automation moved this from In progress to Reviewer approved Oct 10, 2020
@worldofpeace worldofpeace merged commit 38237e9 into NixOS:master Oct 10, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be2f1cb"; rev="be2f1cb15c1437bd8360d6727c82a086a447d09d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
20.09 Blockers automation moved this from Reviewer approved to Done Oct 10, 2020
@worldofpeace worldofpeace deleted the jtojnar:fontconfig-rn branch Oct 10, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Oct 10, 2020

backported in dd03915

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Oct 10, 2020

Thanks for fixing this @jtojnar 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.