Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cut-the-crap: 1.4.2 Mark unbroken #100107

Merged
merged 2 commits into from Oct 10, 2020
Merged

Conversation

@jappeace
Copy link
Contributor

@jappeace jappeace commented Oct 9, 2020

I fixed this upstream by adding c2hs to cabal as a built tool.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
I fixed this by adding c2hs to cabal as a built tool.
@jappeace
Copy link
Contributor Author

@jappeace jappeace commented Oct 9, 2020

For version of cut-the-crap 2 I need to add youtube-dl to the overrides, so I'll come back to this.

@jappeace jappeace closed this Oct 9, 2020
@jappeace jappeace reopened this Oct 10, 2020
@jappeace
Copy link
Contributor Author

@jappeace jappeace commented Oct 10, 2020

I realized that the version 2 changes should not affect the building, but I also added youtube-dl to the path which is harmless for version 1, but used if urls are provided instead of paths in version 2.

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Oct 10, 2020

Looks good, thanks!

@cdepillabout cdepillabout merged commit f7e72e7 into NixOS:haskell-updates Oct 10, 2020
16 checks passed
16 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2005dbf"; rev="2005dbf5a83bac383776c719c051266dd012580d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.