Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: 2019 -> 2020 #100121

Merged
merged 6 commits into from Oct 11, 2020
Merged

texlive: 2019 -> 2020 #100121

merged 6 commits into from Oct 11, 2020

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Oct 10, 2020

Motivation for this change

Provide minor fixes for some items in texlive.bin. Update to the latest texlive snapshot.
Closes: #91994

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
nix path-info -h -S /nix/store/vb3l4zhkigrniqh400vl96qly8kpbhd1-texlive-combined-full-2020 -S /nix/store/0rlzarjqrplckcfdydk22na48dfj7zk9-texlive-combined-full-2019
/nix/store/0rlzarjqrplckcfdydk22na48dfj7zk9-texlive-combined-full-2019     3.4G
/nix/store/vb3l4zhkigrniqh400vl96qly8kpbhd1-texlive-combined-full-2020     3.8G
@gebner
Copy link
Member

@gebner gebner commented Oct 10, 2020

Builds and works for me (tested on a few latex files).

@gebner
Copy link
Member

@gebner gebner commented Oct 11, 2020

This PR is still marked as draft, but pretty much LGTM from my side. Is there anything that you still want to do?

veprbl added 5 commits Oct 9, 2020
This used to be broken, but recently was fixed.
The ppc64 condition is based on previous reports and was not tested on
actual hardware.
Also change default package version from texlive year to a
revision. The problem with using texlive year is that it will change
on each of our update even if the package itself was not updated. The
texlive SVN revision number should not change unless the package is
updated. This will allow to share more store paths between different
texlive versions.
@veprbl veprbl force-pushed the veprbl:pr/texlive_2020 branch from d36db9b to 10438ba Oct 11, 2020
@veprbl
Copy link
Member Author

@veprbl veprbl commented Oct 11, 2020

@gebner Just pushed a new changeset. Main difference is a change of default versioning scheme for unversioned packages, it now uses SVN revision number instead of the texlive year. There are also minor tweaks for luajit (cc @CrystalGamma for ppc64 changes).

We usually had major texlive updates sit for a while before getting merged, but we could try merging sooner this time.

@veprbl veprbl marked this pull request as ready for review Oct 11, 2020
@veprbl
Copy link
Member Author

@veprbl veprbl commented Oct 11, 2020

@GrahamcOfBorg build tests.texlive texlive.combined.scheme-full

@gebner
Copy link
Member

@gebner gebner commented Oct 11, 2020

We usually had major texlive updates sit for a while before getting merged, but we could try merging sooner this time.

I know, in 2017 I merged the texlive update after it had been sitting around for over a month with no activity, and we only got bug reports after it was merged.

We don't gain much by letting this PR sit longer than necessary. If it builds, then I think we should merge it.

@veprbl veprbl merged commit 2cdd6d1 into NixOS:master Oct 11, 2020
20 of 23 checks passed
20 of 23 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
tests.texlive, texlive.combined.scheme-full on x86_64-darwin
Details
texlive.combined.scheme-infraonly, texlive.combined.scheme-infraonly.passthru.tests on x86_64-darwin
Details
tests.texlive, texlive.combined.scheme-full on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10438ba"; rev="10438ba4faae395de29364c4ed87db045aab489c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.texlive, texlive.combined.scheme-full on x86_64-linux Success
Details
texlive.combined.scheme-infraonly, texlive.combined.scheme-infraonly.passthru.tests on aarch64-linux Success
Details
texlive.combined.scheme-infraonly, texlive.combined.scheme-infraonly.passthru.tests on x86_64-linux Success
Details
@gebner
Copy link
Member

@gebner gebner commented Oct 13, 2020

I ran into one regression, the new biber 2.15 doesn't like authors such as Jean{-}Marc. This is already fixed upstream (but not released yet): plk/biber#329

@veprbl veprbl mentioned this pull request Oct 13, 2020
1 of 10 tasks complete
stripLen = 2;
})
];

# remove when removing synctex-missing-header.patch

This comment has been minimized.

@dtzWill

dtzWill Oct 17, 2020
Contributor

Think this should've been removed before, per:comment?

This comment has been minimized.

@veprbl

veprbl Oct 18, 2020
Author Member

@dtzWill Nice catch, this should have been addressed back in update to 2019. Opened #101016. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.