Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdot: add to top-level #100122

Merged
merged 1 commit into from Oct 10, 2020
Merged

xdot: add to top-level #100122

merged 1 commit into from Oct 10, 2020

Conversation

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Oct 10, 2020

Motivation for this change

This adds the xdot tool to the top-level.

xdot seems to be a relatively widely-used package (based on my google searches for graphviz visualizations), but I imagine most users don't necessarily need to be aware that it is in python3Packages.xdot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Oct 10, 2020

I'm not sure who would be a good person to review this, but maybe someone involved with Python, maybe @jonringer?

marsam
marsam approved these changes Oct 10, 2020
@marsam marsam merged commit cf8eb80 into NixOS:master Oct 10, 2020
19 of 20 checks passed
@cdepillabout cdepillabout deleted the xdot branch Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants