Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3packages.sip: 4.19.24 -> 5.5.0.dev2010041444 #100129

Draft
wants to merge 2 commits into
base: master
from

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Oct 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
, packaging
, toml
, pythonOlder
, python

This comment has been minimized.

@FRidh

FRidh Oct 10, 2020
Author Member

unused python

@FRidh
Copy link
Member Author

@FRidh FRidh commented Oct 10, 2020

The pyqt5 configure and build instructions are not really up to date. They say

Prior to the release of SIP v5 the only way to build PyQt5 (and related projects) was based on a configure.py script. This method is now deprecated and will be removed when SIP v6 is released (which is expected to be mid-2020).

however, don't offer any other method (the configuration file needs to be passed to configure.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.