Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/vim: configurable vim package #100132

merged 1 commit into from Oct 15, 2020

nixos/vim: configurable vim package #100132

merged 1 commit into from Oct 15, 2020


Copy link

@oxzi oxzi commented Oct 10, 2020

Motivation for this change

The current vim module is very limited, so only setting vim as the default editor is possible. This results in adding pkgs.vim to the systemPackages and setting the EDITOR environment variable.

However, if one wants to use a custom vim package, an overlay has to be created which is then used. If the same overlay definitions are used for multiple machines, it is not possible to configure different vim packages for different machines in a straight forward way.

This pull request adds a typical package option to the vim module to configure the vim package to be used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@teto teto merged commit 17bcc04 into NixOS:master Oct 15, 2020
17 checks passed
@oxzi oxzi deleted the vim-package branch Oct 15, 2020
@deviant deviant mentioned this pull request Oct 20, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants