Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meshio, expose gmsh python api, add exdown, and add pygmsh #100135

Open
wants to merge 4 commits into
base: master
from

Conversation

@Wulfsta
Copy link
Contributor

@Wulfsta Wulfsta commented Oct 10, 2020

Motivation for this change

Add packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Wulfsta
Copy link
Contributor Author

@Wulfsta Wulfsta commented Oct 10, 2020

@doronbehar You had a look at this the last time I made a PR for some of these packages - I finally got around to working on this again.

@Wulfsta Wulfsta force-pushed the Wulfsta:meshio_and_pygmsh branch from 03c439b to 21826b8 Oct 10, 2020
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 left a comment

Alternative you can also just overwrite the installPhase.

--- /dev/null
+++ b/setup.py
@@ -0,0 +1,3 @@
+import setuptools

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please use echo ... > ... for this.

diff --git a/setup.py b/setup.py
new file mode 100644
index 0000000..b908cbe
--- /dev/null

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please use echo ... > ... for this.

{ stdenv
, buildPythonPackage
, substituteAll
, pkgs

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please do not input pkgs.

This comment has been minimized.

@Wulfsta

Wulfsta Nov 27, 2020
Author Contributor

I have not gotten around to updating this since figuring out the right way to do it here.

__version__ = GMSH_API_VERSION

oldsig = signal.signal(signal.SIGINT, signal.SIG_DFL)
-libdir = os.path.dirname(os.path.realpath(__file__))

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please use ``substitute --replace 'in' 'out'.

This comment has been minimized.

@Wulfsta

Wulfsta Nov 27, 2020
Author Contributor

I don't follow, can you elaborate?

index 0000000..b908cbe
--- /dev/null
+++ b/setup.py
@@ -0,0 +1,3 @@

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please use echo ... > ... for this.

new file mode 100644
index 0000000..b908cbe
--- /dev/null
+++ b/setup.py

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please use echo ... > ... for this.

checkInputs = [ pytest ];

checkPhase = ''
pytest

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Please use pytestCheckHook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.