Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.google_cloud_dataproc: Fix package by adding missing dependencies #100138

Merged
merged 3 commits into from Oct 11, 2020

Conversation

@ruuda
Copy link
Contributor

@ruuda ruuda commented Oct 10, 2020

Motivation for this change

ZHF: #97479

The package was broken because two of its dependencies were missing. They were not yet packaged, so I added both.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The ZHF issue says

Please ping @NixOS/nixos-release-managers on the PR.

But it is unclear to me if that is about this PR, or about the backporting one, so I’ll ping you here.

@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

I think you might need to set libcst to disabled = !isPy3k;

@ruuda
Copy link
Contributor Author

@ruuda ruuda commented Oct 10, 2020

I think you might need to set libcst to disabled = !isPy3k;

You are right, it uses type annotations so it doesn’t parse on Python 2. Fixed, please take another look.

@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

Cool - this is working for me now, macos 10.14 & non-nixos linux x86_64. Could you squash the commits down to 1 per package please?

ruuda added 3 commits Oct 10, 2020
I am adding this package because it is a dependency of
google_cloud_dataproc.
I am adding this package because it is a dependency of
google_cloud_dataproc.
@ruuda ruuda force-pushed the ruuda:google-cloud-dataproc branch from 17b938b to f922206 Oct 10, 2020
@ruuda
Copy link
Contributor Author

@ruuda ruuda commented Oct 10, 2020

Could you squash the commits down to 1 per package please?

Yes, done.

@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

If you add

  checkInputs = [ pytestCheckHook google_api_core ];

to proto-plus it will actually find and run the tests. At the moment it's just giving up and skipping them because it can't find any unittest-based ones.

@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

...and that reveals that proto-plus also needs to be disabled = !isPy3k.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100138 1

7 packages built:
  • python27Packages.proto-plus
  • python37Packages.google_cloud_dataproc
  • python37Packages.libcst
  • python37Packages.proto-plus
  • python38Packages.google_cloud_dataproc
  • python38Packages.libcst
  • python38Packages.proto-plus

@jonringer jonringer merged commit 9e51c25 into NixOS:master Oct 11, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f922206"; rev="f922206bba2b9112f53306ab76016dbb639494ed"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.