Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadered: init at 1.4.1 #100140

Merged
merged 1 commit into from Jan 24, 2021
Merged

shadered: init at 1.4.1 #100140

merged 1 commit into from Jan 24, 2021

Conversation

@Scriptkiddi
Copy link
Contributor

@Scriptkiddi Scriptkiddi commented Oct 10, 2020

Motivation for this change

issue #99639

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Oct 11, 2020

works for me

@Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Oct 13, 2020

Now I get

terminate called after throwing an instance of 'std::filesystem::__cxx11::filesystem_error'
  what():  filesystem error: cannot create directory: Read-only file system [./temp/]

@Scriptkiddi
Copy link
Contributor Author

@Scriptkiddi Scriptkiddi commented Oct 14, 2020

Now I get

terminate called after throwing an instance of 'std::filesystem::__cxx11::filesystem_error'
  what():  filesystem error: cannot create directory: Read-only file system [./temp/]

This is a problem in shadered dfranx/SHADERed#135

@Scriptkiddi Scriptkiddi requested a review from ajs124 Oct 23, 2020
pkgs/development/tools/shadered/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/shadered/default.nix Show resolved Hide resolved
pkgs/development/tools/shadered/default.nix Show resolved Hide resolved
pkgs/development/tools/shadered/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100140 run on x86_64-linux 1

1 package built:
  • shadered

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/shadered/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/shadered/default.nix Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit f752e4d into NixOS:master Jan 24, 2021
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants