Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ansible: split into ansible and ansible-base, update to 2.10.x #100147

Closed
wants to merge 4 commits into from

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 10, 2020

Motivation for this change

This is a mess.

In v2.10 the ansible package was split into collections (ansible) and engine (ansible-base).

The ansible package requires ansible-base.
The ansible-base package holds the executables.

This means I cannot introduce ansible (the collections) as a propagatedBuildInput into ansible-base (the engine), because it would create an inifinite loop. Installing the ansible package, instead of ansible-base would prevent the executables from the ansible-base package from landing in the PATH.

The ansible packagers clearly assume a global python path, where these things just work. Looking for good ideas on how to continue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt mweinelt changed the title python3Packagesansible: split into ansible and ansible-base, update to 2.10.x python3Packages.ansible: split into ansible and ansible-base, update to 2.10.x Oct 10, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100147 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python27Packages.ansible
  • python27Packages.ansible-base
  • python27Packages.pytest-ansible
15 packages built:
  • ansible (ansible_2_10 ,python38Packages.ansible-base)
  • ansible-lint (python38Packages.ansible-lint)
  • ansible_2_8
  • ansible_2_9
  • kargo
  • python37Packages.ansible
  • python37Packages.ansible-base
  • python37Packages.ansible-kernel
  • python37Packages.ansible-lint
  • python37Packages.ansible-runner
  • python37Packages.pytest-ansible
  • python38Packages.ansible
  • python38Packages.ansible-kernel
  • python38Packages.ansible-runner
  • python38Packages.pytest-ansible

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 7, 2021

The ansible package requires ansible-base.
The ansible-base package holds the executables.

Create a boolean flag to include executables in ansible and include the ansible without them in ansible-base.

@mweinelt mweinelt mentioned this pull request May 12, 2021
10 tasks
@mweinelt mweinelt closed this May 12, 2021
@mweinelt mweinelt deleted the ansible branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants