Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.fs: fix tests on darwin #100149

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@tricktron
Copy link
Contributor

@tricktron tricktron commented Oct 10, 2020

Motivation for this change

Backport of #98619
ZHF: #97479
cc: @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Refactors to pytestCheckHook and removes unused nose dependency.

(cherry picked from commit 66afda2)
@risicle
Copy link
Contributor

@risicle risicle commented Oct 10, 2020

WFM macos 10.14, non-nixos linux x86_64.

I'm a bit hesitant to merge this because of all the rebuilds, but I don't know whether people are planning to make much use of staging-20.09.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 11, 2020

save machine learning libraries, python libraries are considered pretty "cheap".

I think this is a benefit for mac, so we should merge.

@jonringer jonringer merged commit c8f9a54 into NixOS:release-20.09 Oct 11, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants