Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elinks: 0.13.2 -> 0.13.5 #100152

Merged
merged 1 commit into from Oct 10, 2020
Merged

elinks: 0.13.2 -> 0.13.5 #100152

merged 1 commit into from Oct 10, 2020

Conversation

@gebner
Copy link
Member

@gebner gebner commented Oct 10, 2020

Motivation for this change

elinks doesn't build at the moment, because it depends on a spidermonkey version marked as insecure. (I don't know who changed the dependency to spidermonkey_38; the only supported version is 17.)

Also: new upstream release. According to the description, we're already tracking the felinks fork. Now we're fetching the github release directly instead of fetching the debian sources.

I've also disabled javascript support because we do not package spidermonkey 17. Even if we did, it's outdated and shouldn't be used in a web browser. Upstream is working on this: rkd77/felinks#29
Closes #71063

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@gebner gebner force-pushed the gebner:elinks0135 branch from b2032f5 to cbdc487 Oct 10, 2020
@gebner gebner force-pushed the gebner:elinks0135 branch from cbdc487 to bd8dea8 Oct 10, 2020
@ofborg ofborg bot requested a review from iblech Oct 10, 2020
@gebner gebner merged commit 44c9d7f into NixOS:master Oct 10, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
elinks, elinks.passthru.tests on aarch64-linux Success
Details
elinks, elinks.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd8dea8"; rev="bd8dea89cb28e2c4335b53c72042706195a93e13"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@8573 8573 mentioned this pull request Oct 14, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.