Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcsx2: multiple improvements #100162

Merged
merged 2 commits into from Oct 23, 2020
Merged

pcsx2: multiple improvements #100162

merged 2 commits into from Oct 23, 2020

Conversation

@samuelgrf
Copy link
Contributor

@samuelgrf samuelgrf commented Oct 10, 2020

Motivation for this change

Build pcsx2 with gtk3, this is already done on both Arch and Gentoo.
I updated the pcsx2 version to master, because it would otherwise crash with trace trap (core dumped) when opening menus.

I also enabled x86_64 builds, since it is supported on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@samuelgrf samuelgrf force-pushed the samuelgrf:pcsx2_gtk3-x86_64 branch 2 times, most recently from 442c19d to 7f20ffd Oct 20, 2020
@samuelgrf samuelgrf changed the title pcsx2: build with gtk3 and support x86_64 builds pcsx2: multiple improvements Oct 20, 2020
@samuelgrf
Copy link
Contributor Author

@samuelgrf samuelgrf commented Oct 20, 2020

The last commit enables building with LTO, this should be tested on darwin.

@samuelgrf samuelgrf force-pushed the samuelgrf:pcsx2_gtk3-x86_64 branch from 7f20ffd to f21ced0 Oct 21, 2020
@samuelgrf samuelgrf requested a review from jtojnar Oct 21, 2020
@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 21, 2020

Thanks for the changes and sorry for not responding earlier. It somehow got lost in my mails and I completely missed this PR till today. I am currently on the road, but will give it a try and thorough look soon (hopefully tomorrow).

@hrdinka hrdinka merged commit 972ba80 into NixOS:master Oct 23, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
pcsx2, pcsx2.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f21ced0"; rev="f21ced0bb5cb480a90385964b0db116f77b13dc4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pcsx2, pcsx2.passthru.tests on x86_64-linux Success
Details
@hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Oct 23, 2020

Tested locally. One less GTK2 App and a lot of gone problems, thanks for all the changes! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.